Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #7829] Fix an error for Style/OneLineConditional #7830

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

koic
Copy link
Member

@koic koic commented Mar 30, 2020

Fixes #7829.

This PR fixes an error for Style/OneLineConditional when one of the branches contains next keyword.

SelfNode was introduced by #7729 to prevent NoMethodErrror, but it is unnecessary because the cop that caused the error were fixed.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes rubocop#7829.

This PR fixes an error for `Style/OneLineConditional`
when one of the branches contains `next` keyword.

`SelfNode` was introduced by rubocop#7729 to prevent `NoMethodErrror`,
but it is unnecessary because the cop that caused the error were
fixed.
@bbatsov bbatsov merged commit 40b8771 into rubocop:master Mar 30, 2020
@koic koic deleted the fix_an_error_for_one_line_conditional branch March 30, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined method `prefix_not? in Style/OneLineConditional
2 participants